Omni-node: Manual-seal uses proper aura digests #9885
Conversation
|
/cmd prdoc --audience runtime_dev runtime_user --bump major --force |
…time_dev runtime_user --bump major --force'
# Conflicts: # cumulus/polkadot-omni-node/lib/src/nodes/aura.rs
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
/cmd fmt |
|
Command "fmt" has failed ❌! See logs here |
| block_announce_validator_builder: None, | ||
| warp_sync_config: None, | ||
| block_relay: None, | ||
| metrics: NotificationMetrics::new(None), |
There was a problem hiding this comment.
dq: We are not using the config.prometheus_metrics because we don't want to expose extra backend metrics?
There was a problem hiding this comment.
The manual-seal node is just for local dev, to get some blocks out and test your runtime. We could skip the entire instantiation of the networking IMO, since the blocks are not supposed to sync anywhere. But yeah, some of the components lower down expect network currently, so I am instantiating it but keeping everything as slim as possible.
There was a problem hiding this comment.
Oki doki makes perfect sense, thanks!
Before this change we did not care about parachain slots in manual-seal mode, because para slots that are smaller than their relay parents where allowed. I have changes planned that change this, so the manual-seal needs to be parameterized closer to reality. In this PR I use the `AuraConsensusDataprovider` to read the inherent timestamp provided and emit a corresponding slot digest. I also removed the `DynNodeSpecExt` and added manual seal methods directly to the `NodeSpec` trait. The assumption before was that the manual seal mode can work independently of consensus information. But this no longer holds true, as we need the proper `AuraId` and runtime APIs attached for example. This was the fastest and simplest way to get this working, and we currently only support `AuraNode` anyway. closes #7453 Prerequisite for mergine #9712, as the old way we did things now causes errors. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Before this change we did not care about parachain slots in manual-seal mode, because para slots that are smaller than their relay parents where allowed. I have changes planned that change this, so the manual-seal needs to be parameterized closer to reality.
In this PR I use the
AuraConsensusDataproviderto read the inherent timestamp provided and emit a corresponding slot digest. I also removed theDynNodeSpecExtand added manual seal methods directly to theNodeSpectrait. The assumption before was that the manual seal mode can work independently of consensus information. But this no longer holds true, as we need the properAuraIdand runtime APIs attached for example. This was the fastest and simplest way to get this working, and we currently only supportAuraNodeanyway.closes #7453
Prerequisite for mergine #9712, as the old way we did things now causes errors.